Add compatibility with Numpy 1.26 and 2.0 #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @timonmerk, I saw that you bumped the package requirements to Numpy 2.0.0 and Pandas 2.2.2, which is fine I think, but maybe it could cause conflicts for end-users. Like, I already found that StreamLit does not support Numpy 2.0.0 yet, so it rolled back to 1.26 when I installed it.
So I added code to be compatible with both old and new versions of Python, all tests are passing and pip is installing the requirements just fine.
I changed the requirements back to Numpy 1.26 (for Python 3.12 compatibility) and Pandas 2.0.0 just to pick a round number.