Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure GH and ModelDB are in sync (same content) #71

Closed
9 tasks done
Tracked by #47
alexsavulescu opened this issue Jan 5, 2023 · 7 comments
Closed
9 tasks done
Tracked by #47

Make sure GH and ModelDB are in sync (same content) #71

alexsavulescu opened this issue Jan 5, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@alexsavulescu
Copy link
Member

alexsavulescu commented Jan 5, 2023

Out of Sync

@alexsavulescu alexsavulescu changed the title Make sure those all are in sync (same content) Make sure GH and ModelDB are in sync (same content) Jan 5, 2023
@alexsavulescu alexsavulescu added the bug Something isn't working label Jan 5, 2023
@RuiLi7222
Copy link
Collaborator

The models: 126637, 139653, 256311, 3808, and 266774 are solved.
Models 246546, 260971, and 265584 still need further attention.

@olupton
Copy link
Collaborator

olupton commented May 25, 2023

Model 267666 (new?) is missing from GitHub.

@olupton
Copy link
Collaborator

olupton commented May 25, 2023

Model 267355 is also missing from GitHub.

@JCGoran
Copy link
Collaborator

JCGoran commented Jan 19, 2024

Has this been resolved? I tried locally comparing all of the models from MODELDB with the ones from GH, and have found no differences between the two (modulo some unnecessary files/directories like __MACOSX, .DS_Store, __pycache__, etc.), nor any missing models.
For reference, I used this Bash script for downloading and comparing the files: https://gist.github.com/JCGoran/8e12f8a1aac70203c1f4e8a56171f088

@pramodk
Copy link
Member

pramodk commented Jan 19, 2024

@JCGoran - if the two "unchecked" versions are now synced / same then it's OK to close this ticket. I added you to the #modeldb slack channel on NEURON-Dev where you can see related discussion / post additional questions.

@ramcdougal
Copy link
Member

ramcdougal commented Jan 19, 2024

All ModelDB entries (not just NEURON models) should be in GitHub... Although having said this, I wonder if this is true for alternate model entries.

If you have a list of the entries with the extra files that aren't needed, that would be very helpful so we can clean them up.

@JCGoran
Copy link
Collaborator

JCGoran commented Jan 19, 2024

@ramcdougal I've made some ad-hoc Bash scripts which can be used to clean up the models on MODELDB (can probably be used on the GH ones as well, though I haven't tried it) in case it's of use: https://gist.github.com/JCGoran/c179761e47eee831134fa74f8b304061

@pramodk pramodk closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants