Improve .mod search strategy #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should avoid having to explicitly set model_dir for models with a simple directory structure.
|
https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/5354503218 is running with all models. |
alexsavulescu
approved these changes
Jun 23, 2023
|
Launched https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/5356475106 with all models. |
|
https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/5358611403 passed with all models and aff0e03. |
This was referenced Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should avoid having to explicitly set model_dir for models with a simple directory structure.
Unfortunately this exposes various models with
.modfiles that do not compile, which were previously missed because there was nomodel_dirsetting and the.modfiles were not at the top level.The following 30 models are now skipped, because their
.modfiles do not compile: 7907 125385 144579 147141 154096 155735 155796 182134 183014 183718 184497 229585 230861 237469 239421 240116 246546 256311 261460 265523 266732 266799 266806 266864 267146 267189 267511 267587 267595 267646.Additionally new model 241169 is not executed, because it makes invalid assumptions that break with
neuron-nightly.