Skip to content

Commit

Permalink
typo when setting NRN_COVERAGE_FLAGS (#2530)
Browse files Browse the repository at this point in the history
* NRN_COVERAGE_LIB does not need to be set to gcov anymore.
  • Loading branch information
nrnhines committed Sep 24, 2023
1 parent f1db2b5 commit 40ae342
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions cmake/Coverage.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ if(NRN_ENABLE_COVERAGE)
message(WARNING "Using CMAKE_BUILD_TYPE=Debug is recommended with NRN_ENABLE_COVERAGE")
endif()
set(NRN_COVERAGE_FLAGS_UNQUOTED --coverage -fno-inline)
string(JOIN " " NRN_COVERAGE_FLAGS ${NRN_COVERAGE_FLAGS})
set(NRN_COVERAGE_LIB gcov)
string(JOIN " " NRN_COVERAGE_FLAGS ${NRN_COVERAGE_FLAGS_UNQUOTED})
set(NRN_COVERAGE_LINK_FLAGS --coverage)

if(NRN_COVERAGE_FILES)
Expand All @@ -60,11 +59,11 @@ if(NRN_ENABLE_COVERAGE)
"${NRN_COVERAGE_FLAGS}"
CACHE INTERNAL "Remind that this is always in effect from now on" FORCE)
list(APPEND NRN_COMPILE_FLAGS ${NRN_COVERAGE_FLAGS_UNQUOTED})
list(APPEND NRN_LINK_FLAGS ${NRN_COVERAGE_LINK_FLAGS})
list(APPEND CORENRN_EXTRA_CXX_FLAGS ${NRN_COVERAGE_FLAGS_UNQUOTED})
list(APPEND CORENRN_EXTRA_MECH_CXX_FLAGS ${NRN_COVERAGE_FLAGS_UNQUOTED})
list(APPEND CORENRN_EXTRA_LINK_FLAGS ${NRN_COVERAGE_LINK_FLAGS})
endif()
list(APPEND NRN_LINK_FLAGS ${NRN_COVERAGE_LINK_FLAGS})
list(APPEND CORENRN_EXTRA_LINK_FLAGS ${NRN_COVERAGE_LINK_FLAGS})
list(APPEND NRN_COMPILE_DEFS NRN_COVERAGE_ENABLED)
else()
unset(NRN_COVERAGE_FLAGS)
Expand Down

0 comments on commit 40ae342

Please sign in to comment.