Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxd should not be imported unless it's at the request of the user #2367

Closed
ramcdougal opened this issue Jun 2, 2023 · 0 comments · Fixed by #2424
Closed

rxd should not be imported unless it's at the request of the user #2367

ramcdougal opened this issue Jun 2, 2023 · 0 comments · Fixed by #2424
Assignees
Labels
bug rxd reaction-diffusion
Milestone

Comments

@ramcdougal
Copy link
Member

Context

Overview of the issue

Opening ModelView with Python available requires numpy, which I think is because it loads the rxd module to look for reaction-diffusion dynamics. (rxd does require numpy.)

See https://www.neuron.yale.edu/phpBB/viewtopic.php?p=19899

Expected result/behavior

numpy should not be required for users only using HOC with no reaction-diffusion.

Possible fix

Importing rxd should set a "private" flag somewhere, probably in the top level neuron module, that ModelView can check for before attempting to load rxd itself.

@ramcdougal ramcdougal added bug rxd reaction-diffusion labels Jun 2, 2023
@ramcdougal ramcdougal added this to the Release v9.0 milestone Jun 2, 2023
sgamiye added a commit that referenced this issue Jul 14, 2023
Fixes numpy import error in model view when user is not using rxd; closes #2367
ramcdougal pushed a commit that referenced this issue Oct 20, 2023
…oses #2367 (#2424)

Co-authored-by: Rickeim Gourdine <rickeim.gourdine@yale.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rxd reaction-diffusion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants