Add support for different geometries on different sections of the same region. #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e region. Fix an issue with multicompartment reactions with regions with some different sections.
ramcdougal
requested changes
Feb 18, 2021
ramcdougal
approved these changes
Feb 18, 2021
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 13, 2021
…e region. (#1000) * Add support for different geometries on different sections of the same region. Fix an issue with multicompartment reactions with regions with some different sections. * Add test data. * Fix test for python2. * Fix missing `sec` following @ramcdougal's review
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 30, 2021
…e region. (#1000) * Add support for different geometries on different sections of the same region. Fix an issue with multicompartment reactions with regions with some different sections. * Add test data. * Fix test for python2. * Fix missing `sec` following @ramcdougal's review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with multicompartment reactions between regions with some different sections.