Partrans cover #1051
Merged
Partrans cover #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more convenient for more complicated messages for hoc_execerror(const char*, const char*) Avoid issues when creating 0 length arrays in pc.setup_transfer().
Message truncates after 512 bytes. fileio.cpp no -Wall warnings.
Experiencing two problems: 1) threads 2) voltage source with extracellular inserted and two targets for it.
Enabled by '-DNRN_ENABLE_COVERAGE=ON' (default, coverage of everything).
-DNRN_COVERAGE_FILES='semicolon;list;of;files;to;cover'
The files are relative to PROJECT_SOURCE_DIR, e.g.src/nrniv/partrans.cpp
and, for now, can only be the sources involved in the nrniv_lib target.
Provides:
'make cover_begin' to initialize coverage.
'make cover_html' generate an html report with all coverage
since last 'make cover_begin'
| # Specific coverage files: | ||
| # - OFF : Disable code coverage. | ||
| # - ON : Collect code coverage for files (default all). | ||
| # - <string> : semicolon (;) separated list of files to collect coverage. |
Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
The consequence of fewer functions increases function coverage from 79% to 93%.
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
+ Coverage 29.29% 30.57% +1.28%
==========================================
Files 570 570
Lines 108683 108666 -17
==========================================
+ Hits 31835 33227 +1392
+ Misses 76848 75439 -1409
Continue to review full report at Codecov.
|
Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
alexsavulescu
approved these changes
Mar 8, 2021
Coverage functions 100% and lines 99.6%.
pramodk
approved these changes
Mar 11, 2021
alexsavulescu
added a commit
that referenced
this pull request
Apr 13, 2021
* hoc_execerr(const char* fmt, ...) more convenient for more complicated messages than hoc_execerror(const char*, const char*) Message truncated after 512 bytes. * docstring for hoc_execerr(const char fmt, ...) * Cmake configured code coverage. Enabled by '-DNRN_ENABLE_COVERAGE=ON' (default, coverage of everything). -DNRN_COVERAGE_FILES='semicolon;list;of;files;to;cover' The files are relative to PROJECT_SOURCE_DIR, e.g.src/nrniv/partrans.cpp and, for now, can be any sources underneath nrn/src. Provides: 'make cover_begin' to initialize coverage. 'make cover_html' generate an html report with all coverage since last 'make cover_begin' * Edit cmake and coverage docs * Use a KSChan HGap to help with Impedance tests. * partrans.cpp: replace OS/list.h and nrnhash.h with std:... The consequence of fewer functions increases function coverage from 79% to 93%. * partrans: -Wall warning free * partrans.cpp improve some error messages Coverage functions 100% and lines 99.6%. Co-authored-by: Pramod Kumbhar <pramod.s.kumbhar@gmail.com> Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
alexsavulescu
added a commit
that referenced
this pull request
Apr 14, 2021
This reverts commit 4796c3b.
alexsavulescu
added a commit
that referenced
this pull request
Apr 30, 2021
* hoc_execerr(const char* fmt, ...) more convenient for more complicated messages than hoc_execerror(const char*, const char*) Message truncated after 512 bytes. * docstring for hoc_execerr(const char fmt, ...) * Cmake configured code coverage. Enabled by '-DNRN_ENABLE_COVERAGE=ON' (default, coverage of everything). -DNRN_COVERAGE_FILES='semicolon;list;of;files;to;cover' The files are relative to PROJECT_SOURCE_DIR, e.g.src/nrniv/partrans.cpp and, for now, can be any sources underneath nrn/src. Provides: 'make cover_begin' to initialize coverage. 'make cover_html' generate an html report with all coverage since last 'make cover_begin' * Edit cmake and coverage docs * Use a KSChan HGap to help with Impedance tests. * partrans.cpp: replace OS/list.h and nrnhash.h with std:... The consequence of fewer functions increases function coverage from 79% to 93%. * partrans: -Wall warning free * partrans.cpp improve some error messages Coverage functions 100% and lines 99.6%. Co-authored-by: Pramod Kumbhar <pramod.s.kumbhar@gmail.com> Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two new features that I find very helpful for coverage.
make cover_beginandmake cover_html-DNRN_COVERAGE_FILES="semicolon;separated;list;of;files;" limits coverage to those files. I've found that the workflow cycle
speeds up very satisfyingly
expect_errorfunction.I built with
At present in test/pynrn
gives for src/nrniv/partrans.cpp