Move MPIEXEC_NAME setting to top-level cmake #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
approved these changes
Apr 6, 2021
|
(I think the failures are because GitHub changed something and the builds hit resource limits; in #1137 I tested removing |
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
=======================================
Coverage 31.35% 31.35%
=======================================
Files 571 571
Lines 108810 108810
=======================================
Hits 34121 34121
Misses 74689 74689 Continue to review full report at Codecov.
|
pramodk
approved these changes
Apr 6, 2021
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 13, 2021
alexsavulescu
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience we set in various places the CMake variable
MPIEXEC_NAME. Intest/external/CMakeLists.txtthis was not placed inside a test for MPI and caused the build to fail in some cases. This PR sets the variable in the top-level CMakeLists.txt so that the variable can be used everywhere.This fixes #1140