Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated hclass's __all__ attribute #1188

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

Helveg
Copy link
Contributor

@Helveg Helveg commented Apr 17, 2021

Slight error in #1096, forgot to remove nonlocal_hclass from the module's __all__ attribute

@Helveg Helveg requested a review from ramcdougal April 17, 2021 11:31
@codecov-commenter
Copy link

Codecov Report

Merging #1188 (0ebc39a) into master (decb116) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1188      +/-   ##
==========================================
- Coverage   31.65%   31.57%   -0.09%     
==========================================
  Files         572      572              
  Lines      108966   108966              
==========================================
- Hits        34494    34406      -88     
- Misses      74472    74560      +88     
Impacted Files Coverage Δ
share/lib/python/neuron/hclass3.py 86.66% <100.00%> (ø)
src/parallel/bbssrvmpi.cpp 13.92% <0.00%> (-29.12%) ⬇️
src/parallel/bbsclimpi.cpp 29.87% <0.00%> (-21.43%) ⬇️
src/nrnmpi/bbsmpipack.cpp 74.01% <0.00%> (-12.43%) ⬇️
src/parallel/bbssrv2mpi.cpp 51.14% <0.00%> (-3.45%) ⬇️
src/parallel/bbs.cpp 62.91% <0.00%> (-1.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update decb116...0ebc39a. Read the comment docs.

@Helveg
Copy link
Contributor Author

Helveg commented Apr 17, 2021

How could this ever change code coverage? 🤣

@pramodk
Copy link
Member

pramodk commented Apr 17, 2021

How could this ever change code coverage? 🤣

Yeah...I haven't fully understood report - or - haven't been carefully looking at the numbers 😄

@Helveg
Copy link
Contributor Author

Helveg commented Apr 17, 2021

Oh it's in unrelated files, maybe the tests have non deterministic code paths, it's in the parallel code?

@ramcdougal ramcdougal merged commit 5fc53be into neuronsimulator:master Apr 17, 2021
@Helveg Helveg deleted the helveg/hclass/all-fix branch April 17, 2021 16:57
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants