Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import fails if wheel package is not installed #1223

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

alexsavulescu
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #1223 (e5a266c) into master (f120189) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
- Coverage   31.94%   31.86%   -0.08%     
==========================================
  Files         572      572              
  Lines      108986   108986              
==========================================
- Hits        34814    34728      -86     
- Misses      74172    74258      +86     
Impacted Files Coverage Δ
src/parallel/bbssrvmpi.cpp 13.92% <0.00%> (-29.12%) ⬇️
src/parallel/bbsclimpi.cpp 29.87% <0.00%> (-20.13%) ⬇️
src/nrnmpi/bbsmpipack.cpp 74.01% <0.00%> (-12.43%) ⬇️
src/parallel/bbssrv2mpi.cpp 51.14% <0.00%> (-3.45%) ⬇️
src/parallel/bbs.cpp 62.91% <0.00%> (-1.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f120189...e5a266c. Read the comment docs.

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I feel like I saw this earlier? 🤔

@alexsavulescu
Copy link
Member Author

LGTM - I feel like I saw this earlier? 🤔

Yup, in the nmodl extra PR

@alexsavulescu alexsavulescu merged commit 0466904 into master Apr 28, 2021
@pramodk
Copy link
Member

pramodk commented Apr 28, 2021

Just a note - we delete branch on PR merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants