Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inform users Python3.5 will be dropped #1224

Merged
merged 1 commit into from
Apr 29, 2021
Merged

inform users Python3.5 will be dropped #1224

merged 1 commit into from
Apr 29, 2021

Conversation

alexsavulescu
Copy link
Member

  • add warning in autotools
  • add warning in CMake

@codecov-commenter
Copy link

Codecov Report

Merging #1224 (f7d17f3) into master (e642437) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
+ Coverage   31.86%   31.94%   +0.08%     
==========================================
  Files         572      572              
  Lines      108986   108986              
==========================================
+ Hits        34728    34816      +88     
+ Misses      74258    74170      -88     
Impacted Files Coverage Δ
src/parallel/bbs.cpp 64.78% <0.00%> (+1.87%) ⬆️
src/parallel/bbssrv2mpi.cpp 54.59% <0.00%> (+3.44%) ⬆️
src/nrnmpi/bbsmpipack.cpp 86.44% <0.00%> (+12.42%) ⬆️
src/parallel/bbsclimpi.cpp 51.29% <0.00%> (+21.42%) ⬆️
src/parallel/bbssrvmpi.cpp 43.03% <0.00%> (+29.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e642437...f7d17f3. Read the comment docs.

Comment on lines +688 to +689
elseif(PYTHON_VERSION_MINOR EQUAL 5)
set(PY35_WARNING TRUE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So 4.5 is not considered? 😉 But if the idea is to remove this right after 8.0 then it's ok for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, didn;t want to spend much time on it. It was off the bat, no testing :) but I confirm it works from azure build logs

@nrnhines
Copy link
Member

I'm not sure I see the point of this warning for users who build from source. Isn't it enough just to no longer supply wheels.

@ramcdougal
Copy link
Member

Not supplying wheels and dropping support are two different things. If we drop support for 3.5, then we know e.g. dictionaries are always ordered, and we can simplify code that uses them going forward... And that if somebody builds from source and runs it with 3.5 anyways, things may or may not work.

@pramodk
Copy link
Member

pramodk commented Apr 29, 2021

Also, I was under impression that we had some special code to handle Python 3.5 but could not find it in https://github.com/neuronsimulator/nrn/blob/master/src/nrnpython/nrnpython.cpp

@alexsavulescu
Copy link
Member Author

Also, I was under impression that we had some special code to handle Python 3.5 but could not find it in https://github.com/neuronsimulator/nrn/blob/master/src/nrnpython/nrnpython.cpp

One example here: https://github.com/neuronsimulator/nrn/blob/master/share/lib/python/neuron/hclass35.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants