-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inform users Python3.5 will be dropped #1224
Conversation
alexsavulescu
commented
Apr 28, 2021
- add warning in autotools
- add warning in CMake
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
==========================================
+ Coverage 31.86% 31.94% +0.08%
==========================================
Files 572 572
Lines 108986 108986
==========================================
+ Hits 34728 34816 +88
+ Misses 74258 74170 -88
Continue to review full report at Codecov.
|
elseif(PYTHON_VERSION_MINOR EQUAL 5) | ||
set(PY35_WARNING TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So 4.5
is not considered? 😉 But if the idea is to remove this right after 8.0 then it's ok for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, didn;t want to spend much time on it. It was off the bat, no testing :) but I confirm it works from azure build logs
I'm not sure I see the point of this warning for users who build from source. Isn't it enough just to no longer supply wheels. |
Not supplying wheels and dropping support are two different things. If we drop support for 3.5, then we know e.g. dictionaries are always ordered, and we can simplify code that uses them going forward... And that if somebody builds from source and runs it with 3.5 anyways, things may or may not work. |
Also, I was under impression that we had some special code to handle Python 3.5 but could not find it in https://github.com/neuronsimulator/nrn/blob/master/src/nrnpython/nrnpython.cpp |
One example here: https://github.com/neuronsimulator/nrn/blob/master/share/lib/python/neuron/hclass35.py |