Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rxd.Species keep the corresponding SpeciesOnRegion alive. #1270

Merged
merged 4 commits into from May 11, 2021

Conversation

adamjhn
Copy link
Member

@adamjhn adamjhn commented May 11, 2021

No description provided.

@adamjhn adamjhn added the rxd reaction-diffusion label May 11, 2021
@adamjhn adamjhn requested a review from ramcdougal May 11, 2021 02:50
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #1270 (8500927) into master (53b9b48) will increase coverage by 0.08%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
+ Coverage   31.86%   31.95%   +0.08%     
==========================================
  Files         572      572              
  Lines      108990   108999       +9     
==========================================
+ Hits        34734    34828      +94     
+ Misses      74256    74171      -85     
Impacted Files Coverage Δ
share/lib/python/neuron/rxd/species.py 68.88% <76.92%> (-0.02%) ⬇️
src/parallel/bbs.cpp 64.78% <0.00%> (+1.87%) ⬆️
src/parallel/bbssrv2mpi.cpp 54.59% <0.00%> (+3.44%) ⬆️
src/nrnmpi/bbsmpipack.cpp 86.44% <0.00%> (+12.42%) ⬆️
src/parallel/bbsclimpi.cpp 51.29% <0.00%> (+21.42%) ⬆️
src/parallel/bbssrvmpi.cpp 43.03% <0.00%> (+29.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b9b48...8500927. Read the comment docs.

@pramodk
Copy link
Member

pramodk commented May 11, 2021

How to restart Azure build:

  • Click Details link on the right

image

  • You will be navigated to failed build on dev.azure.com:

image

  • Make sure you are logged-in and your Azure account is added to the neuronsimualtor project on Azure. (ask @pramodk or @alexsavulescu)

  • You can now trigger failed jobs using Run failed jobs:

image

@ramcdougal ramcdougal merged commit 151420b into neuronsimulator:master May 11, 2021
@ramcdougal ramcdougal deleted the speciesonregion_fix branch May 11, 2021 22:32
alexsavulescu pushed a commit that referenced this pull request Jan 28, 2022
* Make rxd.Species keep corresponding SpeciesOnRegion alive.

* Add comment.
@alexsavulescu alexsavulescu mentioned this pull request Mar 22, 2022
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants