Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune clang-format rules #2041

Merged
merged 3 commits into from Oct 27, 2022
Merged

Fine tune clang-format rules #2041

merged 3 commits into from Oct 27, 2022

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Oct 26, 2022

  • declareList, declarePtrList, implementList, implementPtrList macros need special treatment
  • delete a return statement apparently causing an ASan error

@azure-pipelines
Copy link

✔️ b800446 -> Azure artifacts URL

@olupton olupton requested a review from alkino October 27, 2022 15:12
@olupton olupton marked this pull request as ready for review October 27, 2022 15:13
@azure-pipelines
Copy link

✔️ 4184dea -> Azure artifacts URL

@olupton olupton merged commit 71e5ba4 into master Oct 27, 2022
@olupton olupton deleted the olupton/clang-format-fixup branch October 27, 2022 16:07
iomaganaris pushed a commit that referenced this pull request Nov 9, 2022
* declarePtrList / implementPtrList
* declareList / implementList
* Delete return statement to avoid ASan error.
nrnhines added a commit that referenced this pull request Nov 9, 2022
* refactoring: drop java code (#1937)

* Update removed_features.rst

* Fine tune clang-format and fix CI (#2041)

* Delete return statement to avoid ASan error.

* CVode.poolshrink(1) deletes unused mechanism pools. (#2033)

* Pin bokeh<3, don't pin matplotlib (#2048)

* Add list(...) for new matplotlib.

Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
Co-authored-by: nrnhines <michael.hines@yale.edu>
alexsavulescu added a commit that referenced this pull request Dec 15, 2022
* refactoring: drop java code (#1937)

* Update removed_features.rst

* Fine tune clang-format and fix CI (#2041)

* Delete return statement to avoid ASan error.

* CVode.poolshrink(1) deletes unused mechanism pools. (#2033)

* Pin bokeh<3, don't pin matplotlib (#2048)

* Add list(...) for new matplotlib.

Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
Co-authored-by: Olli Lupton <oliver.lupton@epfl.ch>
Co-authored-by: nrnhines <michael.hines@yale.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants