New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup.py: configure RX3D for hoc_module #2272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2272 +/- ##
=======================================
Coverage 56.92% 56.92%
=======================================
Files 619 619
Lines 121485 121485
=======================================
Hits 69150 69150
Misses 52335 52335 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexsavulescu
force-pushed
the
rxd-hoc-spy
branch
from
March 16, 2023 15:59
a65e1d0
to
8e38104
Compare
✔️ a65e1d0 -> Azure artifacts URL |
✔️ 8e38104 -> Azure artifacts URL |
pramodk
approved these changes
Mar 16, 2023
nrnhines
pushed a commit
that referenced
this pull request
Sep 6, 2023
JCGoran
pushed a commit
that referenced
this pull request
Jan 11, 2024
JCGoran
pushed a commit
that referenced
this pull request
Jan 12, 2024
JCGoran
pushed a commit
that referenced
this pull request
Jan 12, 2024
JCGoran
pushed a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
h.nrnversion(6)
givesbut
NRN_ENABLE_RX3D
is actually enabled. This is because historicallyhoc_module
needed to be independent of the CMake build, whereas after #2235 this is no longer a concern.