Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: configure RX3D for hoc_module #2272

Merged
merged 1 commit into from Mar 16, 2023
Merged

setup.py: configure RX3D for hoc_module #2272

merged 1 commit into from Mar 16, 2023

Conversation

alexsavulescu
Copy link
Member

@alexsavulescu alexsavulescu commented Mar 16, 2023

Currently h.nrnversion(6) gives

cmake option default differences: 'NRN_ENABLE_RX3D=OFF' 'NRN_ENABLE_CORENEURON=ON' 'NRN_ENABLE_MODULE_INSTALL=OFF' 'NRN_ENABLE_PYTHON_DYNAMIC=ON' 'NRN_MPI_DYNAMIC=/usr/local/opt/openmpi/include;/usr/local/opt/mpich/include' 'CMAKE_BUILD_TYPE=Release' 'CMAKE_INSTALL_PREFIX=/Users/runner/work/1/s/build/cmake_install' 'CMAKE_C_COMPILER=/Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc' 'CMAKE_CXX_COMPILER=/Applications/Xcode_13.2.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++' 'PYTHON_EXECUTABLE=/Users/runner/work/1/s/nrn_build_venv38_-4745831/bin/python'

but NRN_ENABLE_RX3D is actually enabled. This is because historically hoc_module needed to be independent of the CMake build, whereas after #2235 this is no longer a concern.

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #2272 (8e38104) into master (e631662) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2272   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files         619      619           
  Lines      121485   121485           
=======================================
  Hits        69150    69150           
  Misses      52335    52335           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines
Copy link

✔️ a65e1d0 -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 8e38104 -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit c723caa into master Mar 16, 2023
@alexsavulescu alexsavulescu deleted the rxd-hoc-spy branch March 16, 2023 21:11
@heerener heerener mentioned this pull request Feb 6, 2024
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants