Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For adding only nodes to nodelist. Please check before merging. #2369

Merged
merged 10 commits into from
Jun 21, 2023
Merged

For adding only nodes to nodelist. Please check before merging. #2369

merged 10 commits into from
Jun 21, 2023

Conversation

sgamiye
Copy link
Collaborator

@sgamiye sgamiye commented Jun 2, 2023

No description provided.

@ramcdougal ramcdougal linked an issue Jun 2, 2023 that may be closed by this pull request
rxd.nodelist.NodeList should be restricted to containing rxd.node.Node instances #1686
Closed
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@sgamiye sgamiye marked this pull request as draft June 2, 2023 21:56
@sgamiye sgamiye added the rxd reaction-diffusion label Jun 2, 2023
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ ff111c1 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Merging #2369 (1b7ba27) into master (7197b37) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2369      +/-   ##
==========================================
+ Coverage   60.18%   60.19%   +0.01%     
==========================================
  Files         627      627              
  Lines      121007   121033      +26     
==========================================
+ Hits        72827    72857      +30     
+ Misses      48180    48176       -4
Impacted Files Coverage Δ
share/lib/python/neuron/rxd/nodelist.py 66.66% <100.00%> (+9.21%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
@ramcdougal ramcdougal marked this pull request as ready for review June 20, 2023 18:44
@ramcdougal ramcdougal requested review from ramcdougal and adamjhn and removed request for ramcdougal June 20, 2023 18:45
ramcdougal
ramcdougal requested changes Jun 20, 2023
View reviewed changes
test/rxd/test_nodelist.py Outdated Show resolved Hide resolved
test/rxd/test_nodelist.py Outdated Show resolved Hide resolved
test/rxd/test_nodelist.py Outdated Show resolved Hide resolved
test/rxd/test_nodelist.py Outdated Show resolved Hide resolved
test/rxd/test_nodelist.py Outdated Show resolved Hide resolved
test/rxd/test_nodelist.py Outdated Show resolved Hide resolved
test/rxd/test_nodelist.py Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

✔️ 7ce1b2a -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 1b7ba27 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #133310 (:white_check_mark:) have been uploaded here!

Status and direct links:

@ramcdougal ramcdougal merged commit a85f6ee into master Jun 21, 2023
33 checks passed
@ramcdougal ramcdougal deleted the nodelist_test branch June 21, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramcdougal ramcdougal ramcdougal approved these changes

@adamjhn adamjhn Awaiting requested review from adamjhn

Assignees
No one assigned
Labels
rxd reaction-diffusion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rxd.nodelist.NodeList should be restricted to containing rxd.node.Node instances
3 participants
@sgamiye @bbpbuildbot @ramcdougal