Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Debian stable #2372

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix compilation on Debian stable #2372

merged 1 commit into from
Jun 6, 2023

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jun 6, 2023

A file added in #2027 did not compile with Debian stable: https://github.com/neuronsimulator/nrn-build-ci/actions/runs/5184018307/jobs/9344080598
With this change, it does: https://github.com/neuronsimulator/nrn-build-ci/actions/runs/5186212735/jobs/9347034540

It's not entirely clear why, the minimal reproducer:

template <typename Storage, typename... Tags>
struct soa {
    soa(): soa(Tags{}...) {}
    soa(Tags... tag_instances) {}
    soa(soa&&) = delete;
    soa(soa const&) = delete;
    soa& operator=(soa&&) = delete;
    soa& operator=(soa const&) = delete;
};
struct A {
    using type = float;
};
struct storage: soa<storage, A> {};
void foo() {
    storage data{};
}

fails inside a debian:stable Docker image but does not fail with GCC 10.2 on compiler explorer.
I believe that the error returned on Debian is not valid/correct.

@olupton olupton added improvement Improvement over existing implementation building Issue related to build/compilation dev Developer Tickets labels Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2372 (6a99d78) into master (6c529a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2372   +/-   ##
=======================================
  Coverage   60.15%   60.16%           
=======================================
  Files         642      642           
  Lines      121135   121135           
=======================================
+ Hits        72872    72878    +6     
+ Misses      48263    48257    -6     
Impacted Files Coverage Δ
test/unit_tests/container/container.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@azure-pipelines
Copy link

✔️ 6a99d78 -> Azure artifacts URL

@alexsavulescu alexsavulescu merged commit fb17127 into master Jun 6, 2023
41 checks passed
@alexsavulescu alexsavulescu deleted the olupton/debian branch June 6, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Issue related to build/compilation dev Developer Tickets improvement Improvement over existing implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants