Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPI: put in netpar variables that should not be global #2421

Merged
merged 9 commits into from
Jul 17, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Jul 13, 2023

No description provided.

@azure-pipelines
Copy link

✔️ db9c506 -> Azure artifacts URL

@azure-pipelines
Copy link

✔️ 1e44b47 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2421 (1fbfb17) into master (08bebf0) will increase coverage by 0.00%.
The diff coverage is 86.36%.

@@           Coverage Diff           @@
##           master    #2421   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files         627      627           
  Lines      121090   121089    -1     
=======================================
+ Hits        72905    72906    +1     
+ Misses      48185    48183    -2     
Impacted Files Coverage Δ
src/nrnmpi/mpispike.cpp 78.02% <85.00%> (ø)
src/nrniv/netpar.cpp 96.84% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

@github-actions
Copy link
Contributor

NEURON ModelDB CI: launching for 1e44b47 via its drop url

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link
Member

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsavulescu alexsavulescu marked this pull request as draft July 14, 2023 08:15
@alkino alkino marked this pull request as ready for review July 14, 2023 08:52
@github-actions
Copy link
Contributor

NEURON ModelDB CI: launching for 1e44b47 via its drop url

@azure-pipelines
Copy link

✔️ 1fbfb17 -> Azure artifacts URL

@github-actions
Copy link
Contributor

NEURON ModelDB CI: launching for 1fbfb17 via its drop url

@alkino
Copy link
Member Author

alkino commented Jul 17, 2023

Is it ok to merge?

@alexsavulescu
Copy link
Member

Is it ok to merge?

I will check

@alexsavulescu alexsavulescu merged commit 9a96a3a into master Jul 17, 2023
35 of 36 checks passed
@alexsavulescu alexsavulescu deleted the cornu/prepare_for_mpi branch July 17, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants