Windows CI: Avoid downgrading mingw in CI

[pramodk]

• This reverts commit ff55f81 (Windows CI : downgrade mingw to previously working version (v11.2.0)  #2546)
• See Windows CIs failing (again) #2585 : check if newer image has solved issues seen in Windows CIs failing (again) #2585

[azure-pipelines]

✔️ e335287 -> Azure artifacts URL

[azure-pipelines]

✔️ 8183b09 -> Azure artifacts URL

[azure-pipelines]

✔️ d665dfe -> Azure artifacts URL

[pramodk]

@ramcdougal / @adamjhn : Until #2585 is resolved, could you help us to disable running rxd tests?

I did following change in this PR:

- C:\Python311\python -c "import neuron; neuron.test(); neuron.test_rxd(); quit()" || set "errorfound=y"
+ C:\Python38\python -c "import neuron; neuron.test(); quit()" || set "errorfound=y"

but seems like still the tests under /rxdtests runs?

We have an issue on Azure runner while running rxd tests. So instead of disabling rxd on Windows (as part of the build), I would like to just disable running rxd tests. This way, the installer still has rxd enabled.

[codecov]

Codecov Report

Merging #2596 (5f839e4) into master (ca5730e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2596   +/-   ##
=======================================
  Coverage   66.07%   66.08%           
=======================================
  Files         559      559           
  Lines      108909   108912    +3     
=======================================
+ Hits        71962    71973   +11     
+ Misses      36947    36939    -8     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ramcdougal]

I'm generally opposed to disabling tests to get CI to pass. Many of the commits over the last few weeks have been rxd-related, so it's not like this is an area where things aren't changing.

[pramodk]

I'm generally opposed to disabling tests to get CI to pass. Many of the commits over the last few weeks

Completely agree! I am also not comfortable with just disabling those tests!

Bit of extra info:

• the installer with Rxd works fine on windows. Just that the GitHub windows runner has strange setup that has issue to run rxd tests
• atm, we are a bit blocked now and the Windows CI is not running at all. With the current situation, we don't know if non-rxd tests pass.
• So until Windows CIs failing (again) #2585 is investigated and fixed, if we can just avoid running rxd tests when we check Windows installer then that would be partially helpful. (we are not talking about disabling rxd)

[ramcdougal]

Broadly the pytest code to be run is defined in https://github.com/neuronsimulator/nrn/blob/master/test/CMakeLists.txt

I'm not sure how you'd only disable it for Windows though.

The other thing that should be fixed: it looks like if rx3d is not enabled then no rxd tests run. 3D being disabled (which I still think is an option that should be removed) should only disable 3d tests, not all rxd tests. In fact, being sure that rxd works without 3d enabled is important.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[azure-pipelines]

✔️ 5f839e4 -> Azure artifacts URL

[bbpbuildbot]

Logfiles from GitLab pipeline #165748 (:white_check_mark:) have been uploaded here!

Status and direct links:

• ✅ mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
• ✅ spack_setup
• ✅ build:nmodl
• ✅ build:neuron:nmodl:intel:legacy
• ✅ build:neuron:nmodl:intel:shared
• ✅ build:neuron:nmodl:nvhpc:acc:legacy
• ✅ build:neuron:nmodl:nvhpc:acc:shared
• ✅ build:neuron:nmodl:nvhpc:omp:legacy
• ✅ build:neuron:nmodl:nvhpc:omp
• ✅ test:neuron:nmodl:intel:legacy
• ✅ test:neuron:nmodl:intel:shared
• ✅ test:neuron:nmodl:nvhpc:acc:legacy
• ✅ test:neuron:nmodl:nvhpc:acc:shared
• ✅ test:neuron:nmodl:nvhpc:omp:legacy
• ✅ test:neuron:nmodl:nvhpc:omp

[pramodk]

Broadly the pytest code to be run is defined in https://github.com/neuronsimulator/nrn/blob/master/test/CMakeLists.txt
I'm not sure how you'd only disable it for Windows though.

@ramcdougal : as you might remember, the tests configured in CMake are not executed on Windows. (Due to MingW vs Windows environment differences)

As you can see in the diff of this PR, we are removing call to neuron.test_rxd(); and python share\lib\python\neuron\rxdtests\run_all.py.

In the Test Installer section of Windows setup, you can see what else is currently tested.

I guess this we have to do until find out a way to reproduce/debug & fix the issue.

[nrnhines]

It's good that things work again with the "latest" mingw.
@ramcdougal What is your opinion about restoring rxd tests in a subsequent pull request?