Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hoc_regexp_* by std::regex #2694

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Replace hoc_regexp_* by std::regex #2694

merged 5 commits into from
Jan 30, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Jan 29, 2024

Add an escape_bracket because the original parser used < and > for [ and ].

@alkino alkino requested a review from nrnhines January 29, 2024 15:42
@alkino alkino mentioned this pull request Jan 29, 2024
2 tasks
@alkino alkino linked an issue Jan 29, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification.

Copy link

✔️ 31205fd -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ ccaeb31 -> Azure artifacts URL

Copy link
Contributor

NEURON ModelDB CI: launching for ccaeb31 via its drop url

@bbpbuildbot

This comment has been minimized.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ed0b461) 66.36% compared to head (ccaeb31) 66.42%.

❗ Current head ccaeb31 differs from pull request most recent head e027429. Consider uploading reports for the commit e027429 to get more accurate results

Files Patch % Lines
src/nrnoc/cabcode.cpp 69.23% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2694      +/-   ##
==========================================
+ Coverage   66.36%   66.42%   +0.06%     
==========================================
  Files         559      558       -1     
  Lines      108395   108214     -181     
==========================================
- Hits        71931    71876      -55     
+ Misses      36464    36338     -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alkino
Copy link
Member Author

alkino commented Jan 30, 2024

nrn-modeldb-ci is happy the diff is only:

-mkdir: cannot create directory ‘%model_dir%//data/01292024’: No such file or directory
+mkdir: cannot create directory ‘%model_dir%//data/01302024’: No such file or directory

because the tmpdir is not the same in both errors.

@alkino alkino enabled auto-merge (squash) January 30, 2024 08:50
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
71.8% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ e027429 -> Azure artifacts URL

@alkino alkino merged commit a710366 into master Jan 30, 2024
34 of 35 checks passed
@alkino alkino deleted the cornu/remove_oc_regexp branch January 30, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

always use standard C++ regex
3 participants