Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin packaging to keep LegacyVersion support #2706

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

heerener
Copy link
Collaborator

@heerener heerener commented Feb 5, 2024

Support was dropped in 22.0 (see https://packaging.pypa.io/en/latest/changelog.html#id4 ). This breaks our readthedocs build for any branch that does not parse as a clean version number.

22.0 dropped LegacyVersion: pypa/packaging#407
This makes it so our branches can no longer be parsed as versions
@pramodk pramodk enabled auto-merge (squash) February 5, 2024 15:39
@pramodk pramodk mentioned this pull request Feb 5, 2024
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

✔️ b95b892 -> Azure artifacts URL

@pramodk pramodk merged commit ab5d4e5 into master Feb 5, 2024
34 of 35 checks passed
@pramodk pramodk deleted the heeren/readthedocs-rabbithole branch February 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants