Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setter decorators for some coreneuron attributes #2770

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented Mar 5, 2024

fix #2769

@WeinaJi WeinaJi changed the title Fix#2769: Fix setter decorators for some coreneuron attributes Fix setter decorators for some coreneuron attributes Mar 5, 2024
Copy link

✔️ cb0f449 -> Azure artifacts URL

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 1f4c2c9 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 6dd843d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.15%. Comparing base (8c1473b) to head (81f6a77).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2770   +/-   ##
=======================================
  Coverage   67.15%   67.15%           
=======================================
  Files         561      561           
  Lines      104136   104140    +4     
=======================================
+ Hits        69929    69936    +7     
+ Misses      34207    34204    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ 1306320 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 776fcc5 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 81f6a77 -> Azure artifacts URL

@alkino alkino merged commit 2ec360b into master Apr 5, 2024
37 checks passed
@alkino alkino deleted the weji/coreneuron_getters branch April 5, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In coreneuron.py : getters of some attributes don't work.
4 participants