Replace pkg_resource with importlib.metadata #2778
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2778 +/- ##
=======================================
Coverage 67.14% 67.15%
=======================================
Files 561 561
Lines 104145 104145
=======================================
+ Hits 69930 69935 +5
+ Misses 34215 34210 -5 ☔ View full report in Codecov by Sentry. |
|
@anilbey : just a heads-up, you can see that Azure CI where we build wheels is failing. I didn't check and don't have enough knowledge about this changeset / pkg_resource. But in case it's relevant, I want to mention that we build wheels with two names: |
|
|
||
| package_name = "neuron" | ||
| # Search for NEURON package installation location using importlib.metadata | ||
| for dist in distributions(): |
There was a problem hiding this comment.
I think it's a bit clearer to use metadata("neuron-nightly") in a try..except PackageNotFoundError here as we did for NMODL.
There was a problem hiding this comment.
Hi @JCGoran, ah great so you already did this change for NMODL.
There was a problem hiding this comment.
I actually didn't understand this part. I don't know how the code should behave for neuron-nightly. Do you mind adding this change here?
| @@ -7,7 +7,7 @@ | |||
| import shutil | |||
| import subprocess | |||
| import sys | |||
| from pkg_resources import working_set | |||
| from importlib.metadata import distributions | |||
There was a problem hiding this comment.
importlib.metadata is only present in Python 3.9 and above; since I see NEURON nightly on PyPI still has a 3.8 version available for download, you can use the backported importlib_metadata third-party module for it.
Note that then we also need to update the NEURON recipe for Spack (I think it's this file).
There was a problem hiding this comment.
Thanks I added the backport package.
|
|
Superseded by #2820 |
To address the following deprecation.