Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dev versions #2785

Merged
merged 2 commits into from Mar 19, 2024
Merged

Allow dev versions #2785

merged 2 commits into from Mar 19, 2024

Conversation

heerener
Copy link
Collaborator

The release workflow seems to work with it: https://github.com/neuronsimulator/nrn/actions/runs/8338658007
We might want to create .devX versions to ensure the azure pipeline builds the expected wheel: https://dev.azure.com/neuronsimulator/nrn/_build/results?buildId=11324&view=results (to be determined)

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.58%. Comparing base (35ced5d) to head (ecf1452).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/8.2    #2785      +/-   ##
===============================================
+ Coverage        46.54%   46.58%   +0.03%     
===============================================
  Files              527      527              
  Lines           119281   119282       +1     
===============================================
+ Hits             55520    55568      +48     
+ Misses           63761    63714      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ c236fae -> Azure artifacts URL

@heerener heerener marked this pull request as ready for review March 19, 2024 08:06
Dot required, no trailing numbers
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heerener heerener enabled auto-merge (squash) March 19, 2024 08:31
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ ecf1452 -> Azure artifacts URL

@heerener heerener merged commit a8cd8f5 into release/8.2 Mar 19, 2024
39 checks passed
@heerener heerener deleted the heeren/dev-versions branch March 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants