Clean up CMake after BlueBrain/nmodl#1305 #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `ode.py` integrated into the C++ code, I don't think we need the `PYTHONPATH` handling any longer.
|
|
✔️ 7cdbf65 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2952 +/- ##
==========================================
- Coverage 67.25% 67.25% -0.01%
==========================================
Files 571 571
Lines 104902 104900 -2
==========================================
- Hits 70557 70551 -6
- Misses 34345 34349 +4 ☔ View full report in Codecov by Sentry. |
alkino
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
ode.pyintegrated into the C++ code, I don't think we need thePYTHONPATHhandling any longer.