Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip stub libraries from OSX #670

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Skip stub libraries from OSX #670

merged 1 commit into from
Jul 21, 2020

Conversation

pramodk
Copy link
Member

@pramodk pramodk commented Jul 21, 2020

fixes #669

@pramodk pramodk marked this pull request as ready for review July 21, 2020 22:14
@pramodk pramodk requested a review from nrnhines July 21, 2020 22:14
@pramodk
Copy link
Member Author

pramodk commented Jul 21, 2020

@nrnhines : After merging this to master, I would like to cherry pick this also into 7.8.1 branch so that we can update the released wheels (don't need a separate tag for now).

We didn't notice the problem on OS X because the wheel was tested on same machine where it was built and obviously the mentioned paths were exist. In the future we will set up this CI such way that the wheel will be tested somewhere else.

@nrnhines
Copy link
Member

Not a solution, but don't the tbd files exist if the user installs command line tools (that are needed if the user ever uses nrnivmodl)?

@nrnhines nrnhines merged commit 3ea6c3d into master Jul 21, 2020
@pramodk
Copy link
Member Author

pramodk commented Jul 21, 2020

From my understanding, nrnivmodl doesn't need to link to those libraries to special (?). Also, note that CMake adds absolute path to those libraries like:

/Applications/Xcode_11.5.app/Contents/

These paths exist on the build machine but not on the user machine.

@pramodk pramodk deleted the pramodk/nrn-669 branch July 21, 2020 23:37
nrnhines pushed a commit that referenced this pull request Jul 22, 2020
@pramodk @nrnhines
Skip stub libraries from OSX (#670)
ce4f680 
fixes #669
nrnhines added a commit that referenced this pull request Jul 22, 2020
@nrnhines @pramodk
Rel7.8.1 2 (#672)
da13bb7 
* Observer list iteration bug when iteration removed items. (#666)

InterViews long had this bug fixed but not the ivos copy. So the
problem only occurred when -DNRN_ENABLE_INTERVIEWS=OFF

* Skip stub libraries from OSX (#670)

fixes #669

Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
@pramodk pramodk mentioned this pull request Aug 6, 2020
Merged
@alexsavulescu alexsavulescu mentioned this pull request Dec 8, 2020
Closed
@alexsavulescu alexsavulescu mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

neuron wheel for OSX has links for libcurses.tbd and libform.tbd
2 participants
@pramodk @nrnhines