bugfix: Distribute mulitcompartment reaction fluxes in MPI. #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only currents where being gathered by all nodes. In order to avoid double counting rxd currents, the currents generated by rxd are also distributed to all nodes.
|
@adamjhn : seems like builds are failing because of IV submodule update. If it's not needed in this PR, you can revert IV to older commit and we can fix IV specific build issues separately. |
|
@adamjhn : I didn't change anything. Seems like it was temporary issue on travis which got resolved. |
|
In travis CI log I am randomly seeing: I thought we discussed and workaround it in #559 (comment). For now, I am just re-triggering failed build. |
nrnhines
pushed a commit
that referenced
this pull request
Dec 9, 2020
* bugfix: Distribute mulitcompartment reaction fluxes in MPI. Previously only currents were being gathered by all nodes. In order to avoid double counting rxd currents, the currents generated by rxd are also distributed to all nodes. * Fixed some initialization problems. * Update test results due to a change in when multicompartment fluxes are added. * Fixed a memory problem in the variable step method. * Fix an initialization problem. * Update test data. * Revert external/iv changes.
nrnhines
pushed a commit
that referenced
this pull request
Dec 10, 2020
* bugfix: Distribute mulitcompartment reaction fluxes in MPI. Previously only currents were being gathered by all nodes. In order to avoid double counting rxd currents, the currents generated by rxd are also distributed to all nodes. * Fixed some initialization problems. * Update test results due to a change in when multicompartment fluxes are added. * Fixed a memory problem in the variable step method. * Fix an initialization problem. * Update test data. * Revert external/iv changes.
olupton
pushed a commit
that referenced
this pull request
Dec 7, 2022
* Two factors contribute to the above solution:
- New eigen branch (version 3.5 and above). Currently we are
using a mirrored version of Eigen in BlueBrain organisation
https://github.com/BlueBrain/eigen/releases/tag/v3.5-alpha
- An API that makes possible to call any Eigen `__device__`
function from within OpenACC regions.
* More details: Eigen-3.5+ provides better GPU support; however,
some functions cannot be called directly from within OpenACC regions.
Therefore, we need to wrap them in a special API (decorate them with
`__device__` & `acc routine` tokens), which allows us to eventually call
them from OpenACC. Calling these functions from CUDA kernels presents
no issue.
* From #726: Avoid use `[]` operator with eigen Matrix objects. This results
into runtime error with OpenACC and PGI compiler.
* Note that this should works in combination with BlueBrain/CoreNeuron/pull/624
fixes #311
fixes #135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only currents where being gathered by all nodes. In order to avoid double counting rxd currents, the currents generated by rxd are also distributed to all nodes.