MPI_Abort if hoc_execerror from python and nhost > 1. #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pramodk
approved these changes
Oct 28, 2020
| @@ -700,7 +700,7 @@ void hoc_execerror_mes(const char* s, const char* t, int prnt){ /* recover from | |||
| ctp = cbuf; | |||
| *ctp = '\0'; | |||
|
|
|||
| if (oc_jump_target_) { | |||
| if (oc_jump_target_ && nrnmpi_numprocs_world == 1) { | |||
There was a problem hiding this comment.
With this, for multi-rank run, we don't get stuck in interpreter but abort. Seems reasonable.
nrnhines
added a commit
that referenced
this pull request
Dec 8, 2020
nrnhines
added a commit
that referenced
this pull request
Dec 10, 2020
olupton
added a commit
that referenced
this pull request
Dec 7, 2022
Only use 2 parallel jobs on Linux runners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up recently again and a brute force solution is implemented here. See #642 for a sense in which this is problematic.
@pramodk Please try in your context to see if this resolves your issue.