Fix compilation issue with latest PGI compiler #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we compiling neuron with PGI 20.9 compiler - Same order as CoreNEURON (corresponding file is in external/Random123/include/Random123/features/compilerfeatures.h) - The error I got was `error: identifier "__uint128_t" is undefined` in src/Random123/philox.h because `__uint128_t` is not defined in PGI
nrnhines
approved these changes
Nov 19, 2020
|
@alexsavulescu : any idea why this PR should fail windows CI? |
|
That's pretty rare, looks like the wait or the silent installer get stuck.
I don't think the silent installer can print out progress?
LE: I've also seen it on Azure
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the
compilerfeatures.hso that the proper header file is included when we compilingNEURONwith latestPGIcompiler (20.9)external/Random123/include/Random123/features/compilerfeatures.h)error: identifier "__uint128_t" is undefinedinsrc/Random123/philox.hbecause__uint128_tis not defined in PGI