Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA NEURON CI: cmake action @ latest #929

Closed
wants to merge 4 commits into from
Closed

GHA NEURON CI: cmake action @ latest #929

wants to merge 4 commits into from

Conversation

alexsavulescu
Copy link
Member

Closes #928

nrnhines
nrnhines reviewed Jan 19, 2021
View reviewed changes
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem reasonable. I guess the git actions failures are still a puzzle?

@pramodk
Copy link
Member

pramodk commented Jan 20, 2021

Github has fixed the issue upstream.

@pramodk pramodk closed this Jan 20, 2021
@alexsavulescu
Copy link
Member Author

These seem reasonable. I guess the git actions failures are still a puzzle?

Sorry for the late reply. Root cause was Github API.

@alexsavulescu alexsavulescu deleted the alexsavulescu-patch-1 branch February 10, 2021 23:10
olupton pushed a commit that referenced this pull request Dec 7, 2022
@pramodk
Fix duplicate declaration of conductance variable g (#929)
ea1acbd 
* when user defined g as a range variable in a non-threadsafe
  mod file, then instance structure was declaring g as a member
  variable twice
* now, check if variable is already defined before adding new
  declaration
* this is realted to #888 with mod file glia__dbbs_mod_collection__Nav1_1__0.mod
* print v_unused in case mod file is threadsafe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dev] GitHub Actions CI is failing with "Unable to find version matching 3.8.2"
4 participants
@alexsavulescu @pramodk @nrnhines @alkino