Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a reference to Readme.md #500

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Add a reference to Readme.md #500

merged 3 commits into from
Apr 8, 2021

Conversation

vasudev-sharma
Copy link
Contributor

@vasudev-sharma vasudev-sharma commented Apr 5, 2021 •
edited
Loading

Checklist

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've added relevant tests for my contribution
  • I've updated the documentation and/or added correct docstrings
  • I've assigned a reviewer
  • I've consulted ADS's internal developer documentation to ensure my contribution is in line with any relevant design decisions

Description

This quick PR aims to update the references of the ADS readme. The article that cites ADS --> https://www.sciencedirect.com/science/article/pii/S1361841520303042

Linked issues

@vasudev-sharma vasudev-sharma added the readme context: the changes in the readme file label Apr 5, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.653% when pulling 4e5a0ba on vs/add_citation_readme into ffc79f8 on master.

mariehbourget
mariehbourget approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@mariehbourget mariehbourget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @vs74!

@vasudev-sharma vasudev-sharma merged commit 5fb6a2e into master Apr 8, 2021
@vasudev-sharma vasudev-sharma deleted the vs/add_citation_readme branch April 8, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariehbourget mariehbourget mariehbourget approved these changes

@mathieuboudreau mathieuboudreau Awaiting requested review from mathieuboudreau

Assignees
No one assigned
Labels
readme context: the changes in the readme file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasudev-sharma @coveralls @mariehbourget