Fixed unassigned variable in case -z or -vert is not used #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcohenadad
added
bug
peristeri
reviewed
Jun 12, 2017
scripts/sct_extract_metric.py
Outdated
| @@ -369,6 +369,8 @@ def main(fname_data, path_label, method, slices_of_interest, vertebral_levels, f | |||
| normalizing_label[0], slices_list = remove_slices(normalizing_label[0], slices_of_interest) | |||
| if fname_mask_weight: # if the flag -mask-weighted was specified, | |||
| im_weight.data, slices_list = remove_slices(im_weight.data, slices_of_interest) | |||
| else: | |||
| slices_list = range(0, nz) | |||
There was a problem hiding this comment.
I suggest using np.zeros(nz), because range is an iterable in python3 which would cause break the code.
There was a problem hiding this comment.
np.zeros(nz) doesn't produce the same thing
There was a problem hiding this comment.
Sorry, it is the function np.arange(nz) I was thinking of.
peristeri
approved these changes
Jun 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Default assignment is a list with all slices.
Steps and Constraints
data on /Volumes/folder_shared/sct_issues/20170608_issue1241
command:
Applicable Issues
Fixes #1241