Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improvements to recent tensorflow-tensorboard fix #3082

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Dec 6, 2020

Checklist

GitHub

  • I've given this PR a concise, self-descriptive, and meaningful title
  • I've linked relevant issues in the PR body
  • I've applied the relevant labels to this PR
  • I've assigned a reviewer

PR contents

Description

PR #3034 was included in #3041 to fix #3035. But, on closer inspection, I noticed some issues:

Linked issues

Fixes #3035.

* Combine pip commands into single command
* Remove unnecessary tensorboard reinstall
* Add explanatory comment
@joshuacwnewton joshuacwnewton added the installation category: install_sct or pip/setup.py label Dec 6, 2020
Copy link
Contributor

@lrouhier lrouhier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Thank you for catching that, It makes it more elegant!

@joshuacwnewton joshuacwnewton merged commit e07cd93 into master Dec 7, 2020
@joshuacwnewton joshuacwnewton deleted the jn/3035-apply-tensorboard-fix branch December 7, 2020 18:19
@lrouhier lrouhier added this to the next-release milestone Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation category: install_sct or pip/setup.py
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 versions of tensorboard get installed with SCT
2 participants