Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fractal_higuchi #505

Merged
merged 5 commits into from
Aug 26, 2021
Merged

fix fractal_higuchi #505

merged 5 commits into from
Aug 26, 2021

Conversation

zen-juen
Copy link
Member

@zen-juen zen-juen commented Aug 24, 2021

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targetted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #505 (6e62b0e) into dev (2ee3f4e) will increase coverage by 0.03%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #505      +/-   ##
==========================================
+ Coverage   85.31%   85.34%   +0.03%     
==========================================
  Files         199      199              
  Lines        9736     9740       +4     
==========================================
+ Hits         8306     8313       +7     
+ Misses       1430     1427       -3     
Impacted Files Coverage Δ
neurokit2/complexity/fractal_higuchi.py 95.40% <87.50%> (+1.14%) ⬆️
neurokit2/eda/eda_eventrelated.py 97.95% <0.00%> (-2.05%) ⬇️
neurokit2/complexity/fractal_dfa.py 93.24% <0.00%> (+0.18%) ⬆️
neurokit2/ecg/ecg_delineate.py 79.03% <0.00%> (+0.38%) ⬆️
neurokit2/rsp/rsp_simulate.py 99.10% <0.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee3f4e...6e62b0e. Read the comment docs.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 25, 2021
@Tam-Pham Tam-Pham merged commit 4edcdc5 into dev Aug 26, 2021
@Tam-Pham Tam-Pham deleted the fix/fractal_higuchi branch August 26, 2021 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants