Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize emg offset indices #526

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Sanitize emg offset indices #526

merged 2 commits into from
Sep 2, 2021

Conversation

zen-juen
Copy link
Member

@zen-juen zen-juen commented Sep 1, 2021

#524

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targetted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #526 (917ce9e) into dev (8e71458) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #526      +/-   ##
==========================================
- Coverage   85.34%   85.32%   -0.02%     
==========================================
  Files         199      199              
  Lines        9771     9772       +1     
==========================================
- Hits         8339     8338       -1     
- Misses       1432     1434       +2     
Impacted Files Coverage Δ
neurokit2/emg/emg_activation.py 87.32% <100.00%> (+0.08%) ⬆️
neurokit2/rsp/rsp_simulate.py 94.64% <0.00%> (-5.36%) ⬇️
neurokit2/ecg/ecg_findpeaks.py 93.92% <0.00%> (+0.17%) ⬆️
neurokit2/signal/signal_fixpeaks.py 97.70% <0.00%> (+0.76%) ⬆️
neurokit2/eda/eda_eventrelated.py 100.00% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e71458...917ce9e. Read the comment docs.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Sep 1, 2021
@zen-juen zen-juen merged commit f81bd3a into dev Sep 2, 2021
@zen-juen zen-juen deleted the fix/emg_indices branch September 2, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants