Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rope in summary of stanreg #94

Closed
TobiasBenz opened this issue Sep 18, 2018 · 7 comments
Closed

Rope in summary of stanreg #94

TobiasBenz opened this issue Sep 18, 2018 · 7 comments

Comments

@TobiasBenz
Copy link

Hi,

I am not sure but doing analyze with index = "ROPE" does return the ROPE in the print text but not in the summary table. For Baysian correlation it does include both ROPE and overlap.

I had a quick look at the source and found that the analyze.stanreg does only include the overlap. Is it possible to inlcude the ROPE as well?

Cheers,
Tobi

@TobiasBenz TobiasBenz changed the title Rope in Summary of stanreg Rope in summary of stanreg Sep 18, 2018
@DominiqueMakowski
Copy link
Member

@To-be-b hey yes you're right! In fact, ROPE is a relatively new addition so it's still in the polishing phase but yeah, I'll try to add it to the summary as soon as I have some time (if you manage to add it feel free to make a PR 😉).

@TobiasBenz
Copy link
Author

@DominiqueMakowski Thanks for the quick reply.
I may find some time in October.
It could be vital to add the ROPE to get_contrasts.stanreg as well ( Kruschke, Doing Bayesian data analysis: A tutorial with R, JAGS, and Stan purposes the use of ROPE in Chapt. 19.3.3.)

@DominiqueMakowski
Copy link
Member

Yes, adding to get_contrasts would definitely be a necessary addition! The implementation should be rather straightforward as the function to compute ROPE already exists, so it's just a matter of inserting it and adding it to the tables. Let's keep ourselves updated, but I'll be probably able to look into it in October as well :) Thanks for the suggestion!

@TobiasBenz
Copy link
Author

I added ROPE to the summary. However, I have no permission to push to dev -> no PR

@DominiqueMakowski
Copy link
Member

@To-be-b Great! I've created a PR from dev to master, can you add your commits now?

@TobiasBenz
Copy link
Author

somehow my PR synched now. Is that alright @DominiqueMakowski ?

@DominiqueMakowski
Copy link
Member

It's merged #96 thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants