Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to scale/unscale report plots #762

Closed
adelavega opened this issue May 13, 2020 · 5 comments
Closed

add option to scale/unscale report plots #762

adelavega opened this issue May 13, 2020 · 5 comments

Comments

@adelavega
Copy link
Collaborator

already available in the API

@adelavega adelavega added this to To Do (Frontend) in 0.9 via automation Jun 9, 2020
@rwblair
Copy link
Collaborator

rwblair commented Jun 9, 2020

  • scale by default
  • tooltip
  • toggle button

@adelavega
Copy link
Collaborator Author

Related: #760

@adelavega
Copy link
Collaborator Author

Note to self: only do unit scaling

@rwblair rwblair moved this from To Do (Frontend) to In Progress in 0.9 Jun 22, 2020
@rwblair
Copy link
Collaborator

rwblair commented Jun 22, 2020

@adelavega We don't store a 'scale' boolean in the database right now. The dictionary the api returns for each plot has a config.scale.bandPaddingInner value, which is either 0.015 or 0.0 depending on type of plot.

Then there's encoding.fill.scale, I tried curling against api/analyses/AZ4qk/report?run_id=1233&scale=False and api/analyses/AZ4qk/report?run_id=1233 and the values didn't change. Am I passing the scale boolean properly there?

Is there a way for the front end to determine if a plot is scaled or not or will we need to start tracking that in the database?

@adelavega
Copy link
Collaborator Author

Closed with #788

0.9 automation moved this from In Progress to Done Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.9
  
Done
Development

No branches or pull requests

2 participants