Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add Convolve transformation if there are hrf_variables, fix user pred search #80

Merged
merged 2 commits into from Aug 26, 2020
Merged

Only add Convolve transformation if there are hrf_variables, fix user pred search #80

merged 2 commits into from Aug 26, 2020

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented Aug 19, 2020 •
edited

Two fixes to the create_analysis function:

  • Only add a Convolve transformation is any hrf_variables are specificied
  • Fix user predictor search. Need to loop over missing variables being searched for API to return correct response (not sure why should fix on API side at some point).

@adelavega adelavega mentioned this pull request Aug 21, 2020
Closed
@adelavega adelavega changed the title Only add Convolve transformation if there are hrf_variables Only add Convolve transformation if there are hrf_variables, fix user pred search Aug 21, 2020
@adelavega adelavega merged commit 8437202 into master Aug 26, 2020
@adelavega adelavega deleted the user_preds branch August 26, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adelavega