Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Move files used by examples from tests to resources #605

Merged
merged 17 commits into from Nov 13, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 11, 2021

Closes #589.

Changes proposed in this pull request:

  • Move files used by examples from nimare/tests/data/ to nimare/resources/.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #605 (66b266b) into main (2f93987) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   85.76%   86.05%   +0.29%     
==========================================
  Files          40       40              
  Lines        4390     4390              
==========================================
+ Hits         3765     3778      +13     
+ Misses        625      612      -13     
Impacted Files Coverage Δ
nimare/diagnostics.py 93.10% <0.00%> (+14.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f93987...66b266b. Read the comment docs.

@tsalo
Copy link
Member Author

tsalo commented Nov 12, 2021

The docs build keeps failing due to the following exception and I can't figure out why:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx/events.py", line 101, in emit
    results.append(listener.handler(self.app, *args))
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx_gallery/docs_resolv.py", line 443, in embed_code_links
    _embed_code_links(app, gallery_conf, gallery_dir)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx_gallery/docs_resolv.py", line 354, in _embed_code_links
    cobj, full_fname, return_type=True)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx_gallery/docs_resolv.py", line 260, in resolve
    self._link_cache[full_name] = self._get_link_type(cobj)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx_gallery/docs_resolv.py", line 193, in _get_link_type
    match = self._searchindex['objects'][first][second]
TypeError: list indices must be integers or slices, not str

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx/cmd/build.py", line 280, in build_main
    app.build(args.force_all, filenames)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx/application.py", line 381, in build
    self.events.emit('build-finished', None)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nimare/envs/605/lib/python3.7/site-packages/sphinx/events.py", line 110, in emit
    (listener.handler, name), exc, modname=modname) from exc
sphinx.errors.ExtensionError: Handler <function embed_code_links at 0x7f95666699e0> for event 'build-finished' threw an exception (exception: list indices must be integers or slices, not str)

Extension error (sphinx_gallery.docs_resolv):
Handler <function embed_code_links at 0x7f95666699e0> for event 'build-finished' threw an exception (exception: list indices must be integers or slices, not str)

@tsalo
Copy link
Member Author

tsalo commented Nov 12, 2021

It's not even my fault- it's due to sphinx-gallery/sphinx-gallery#879.

Which means there are a bunch of changes that are probably not necessary...

I don't even need to install doc dependencies for CircleCI, since RTD is handling that now! I just switched the base version for no reason...
@tsalo tsalo merged commit b125357 into neurostuff:main Nov 13, 2021
@tsalo tsalo deleted the move-pain-dset branch November 13, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move NIDM-Results pain dataset from test data to general resources
1 participant