New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Nilearn templates with ones stored in resources folder and unset maximum Nilearn version #621
Conversation
Also note that the "gm" option has been removed.
The NeuroVault example is currently failing, and I think the problem is that the new
While the old nilearn one has the following affine:
I believe this corresponds to a simple flip in the internal array that is cancelled out by the shifted negative value, which means that the maps should be completely compatible. However, I'm not sure what to do about it... EDIT: I just set |
Codecov Report
@@ Coverage Diff @@
## main #621 +/- ##
==========================================
+ Coverage 85.76% 85.85% +0.08%
==========================================
Files 40 40
Lines 4390 4382 -8
==========================================
- Hits 3765 3762 -3
+ Misses 625 620 -5
Continue to review full report at Codecov.
|
Closes #611. The breaking change here is that the
mask="gm"
option no longer works. TemplateFlow did not have tissue type probability maps for the desired templates. Additionally, while the new templates should be essentially the same as the old ones, the affines are slightly different, so some tests and examples had to be adjusted.Changes proposed in this pull request:
tpl-MNI152NLin6Asym
templates from TemplateFlow and store them in the resources folder. Use these templates instead of nilearn functions fornimare.utils.get_template
.MNI152NLin2009cAsym
, I believe) had different dimensions than the one currently used in NiMARE, and those dimension differences meant that images from the NIDM pain dataset had to be resampled, which in turn caused problems for our examples and tests.