Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use beta maps in PermutedOLS instead of z maps #715

Merged
merged 3 commits into from Jun 14, 2022

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Jun 14, 2022

Closes #714.

Changes proposed in this pull request:

  • Use beta maps instead of z maps in PermutedOLS.

@tsalo tsalo added bug Issues noting problems and PRs fixing those problems. ibma Issues/PRs pertaining to image-based meta-analysis labels Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #715 (8147517) into main (035804c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files          41       41           
  Lines        4539     4539           
=======================================
  Hits         3874     3874           
  Misses        665      665           
Impacted Files Coverage Δ
nimare/meta/ibma.py 99.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 035804c...8147517. Read the comment docs.

@tsalo tsalo merged commit 21f960e into neurostuff:main Jun 14, 2022
@tsalo tsalo deleted the fix-permutedols branch June 14, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems. ibma Issues/PRs pertaining to image-based meta-analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PermutedOLS requires z maps, but should use beta maps
1 participant