Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin minimum version of pandas #722

Merged
merged 1 commit into from Jun 23, 2022
Merged

Pin minimum version of pandas #722

merged 1 commit into from Jun 23, 2022

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Jun 18, 2022

using pandas 1.0.3, and 1.0.4 throw errors, but 1.1.0 does not when assigning values to columns that do not yet exist in a pandas dataframe:
(this line)

self.inputs_["coordinates"][["i", "j", "k"]] = ijk

Closes # None.

Changes proposed in this pull request:

  • make minimal pandas version 1.1.0

using pandas 1.0.3, and 1.0.4 throw errors, but 1.1.0 does not
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #722 (ca3bfae) into main (cb542af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #722   +/-   ##
=======================================
  Coverage   85.34%   85.34%           
=======================================
  Files          41       41           
  Lines        4539     4539           
=======================================
  Hits         3874     3874           
  Misses        665      665           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb542af...ca3bfae. Read the comment docs.

@tsalo tsalo added the maintenance Issues/PRs related to maintenance/infrastructure. label Jun 21, 2022
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Do you mind if I update the PR title before merging? We switched away from using the prefixes in favor of labels.

@jdkent
Copy link
Member Author

jdkent commented Jun 23, 2022

sure thing

@tsalo tsalo changed the title [FIX] ensure minimal version of pandas Pin minimum version of pandas Jun 23, 2022
@tsalo tsalo merged commit ac57801 into main Jun 23, 2022
@tsalo tsalo deleted the min-version-pandas branch June 23, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance/infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants