Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pandas.DataFrame.append with pandas.concat #774

Merged
merged 2 commits into from Feb 23, 2023

Conversation

JulioAPeraza
Copy link
Collaborator

@JulioAPeraza JulioAPeraza commented Feb 20, 2023

Closes None.

Changes proposed in this pull request:
pandas.DataFrame.append is deprecated and will be removed in a future version of pandas.

  • Replace pandas.DataFrame.append with pandas.concat.

@JulioAPeraza JulioAPeraza added the maintenance Issues/PRs related to maintenance/infrastructure. label Feb 20, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 88.64% // Head: 88.64% // No change to project coverage 👍

Coverage data is based on head (ff3e257) compared to base (029c42f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files          38       38           
  Lines        4324     4324           
=======================================
  Hits         3833     3833           
  Misses        491      491           
Impacted Files Coverage Δ
nimare/dataset.py 89.57% <100.00%> (ø)
nimare/transforms.py 75.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I didn't see any more places where dataframe appending was being used.

@jdkent
Copy link
Member

jdkent commented Feb 23, 2023

merging, this is a minimal change, thanks!

@jdkent jdkent merged commit bd60a9e into neurostuff:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues/PRs related to maintenance/infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants