Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] make indexed_gzip install optional #791

Merged
merged 1 commit into from Apr 24, 2023

Conversation

jdkent
Copy link
Member

@jdkent jdkent commented Apr 21, 2023

Closes # .

removing indexed_gzip makes NiMARE a pure python package (and therefore usable by pyodide/jupyterlite, etc)

Changes proposed in this pull request:

  • make indexed_gzip installable via [gzip]

@tsalo
Copy link
Member

tsalo commented Apr 21, 2023

If indexed_gzip isn't necessary, it would be great to remove it entirely. It might be good to see if the original issue that led to us requiring indexed_gzip (#399) has been resolved (i.e., hopefully nibabel has dealt with this issue already).

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.17 🎉

Comparison is base (8fdc970) 88.74% compared to head (3bd7623) 88.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   88.74%   88.92%   +0.17%     
==========================================
  Files          41       41              
  Lines        4825     4856      +31     
==========================================
+ Hits         4282     4318      +36     
+ Misses        543      538       -5     
Impacted Files Coverage Δ
nimare/decode/base.py 93.18% <ø> (+2.07%) ⬆️
nimare/decode/continuous.py 96.87% <100.00%> (+2.08%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdkent
Copy link
Member Author

jdkent commented Apr 21, 2023

@tsalo do you know if there was a test written that covered the particular issue you referenced?

@jdkent
Copy link
Member Author

jdkent commented Apr 24, 2023

looks like the ale workflow tests it, so this requirement is likely not necessary, but I prefer to keep it optional for one release before dropping it completely to see if people run into problems.

@jdkent jdkent merged commit 3372f39 into neurostuff:main Apr 24, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants