Unpin numpy version #794
Merged
Unpin numpy version #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulioAPeraza
added
the
maintenance
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 41 41
Lines 4856 4856
=======================================
Hits 4318 4318
Misses 538 538 ☔ View full report in Codecov by Sentry. |
jdkent
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None.
This is an attempt to unpin the maximum version of numpy, given that this issue
https://github.com/numba/numba/issues/8615was closed.Hopefully, this will address one of the issues we have with installing nimare in a pyodide kernel: #785 (comment).