Add Corrector and Diagnostics attributes to MetaResult object #804
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 87.78% 87.82% +0.04%
==========================================
Files 43 43
Lines 5623 5642 +19
==========================================
+ Hits 4936 4955 +19
Misses 687 687
☔ View full report in Codecov by Sentry. |
nimare/tests/test_diagnostics.py
Outdated
|
|
||
| contribution_table = results.tables["z_diag-Jackknife_counts"] | ||
| clusters_table = results.tables["z_clust"] | ||
| label_maps = results.maps["z_PositiveTail"] |
There was a problem hiding this comment.
maybe a little unintuitive what PositiveTail means in this context, may need to make it more explicit that this is a label map and not a statistical map.
There was a problem hiding this comment.
and is the label map represented as a vector or a 3D array? I think the other maps are represented as vectors.
There was a problem hiding this comment.
maybe a little unintuitive what PositiveTail means in this context, may need to make it more explicit that this is a label map and not a statistical map.
Agreed. I've added a couple of new modalities to our bids-like format. See here: https://nimare--804.org.readthedocs.build/en/804/outputs.html#file-names
and is the label map represented as a vector or a 3D array? I think the other maps are represented as vectors.
Good catch! I was missing the np.squeeze.
Thanks!
Closes #800 .
Changes proposed in this pull request:
mapsandtablesdictionaries.