Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine analyses in Studyset #810

Merged
merged 6 commits into from Jun 7, 2023
Merged

Conversation

JulioAPeraza
Copy link
Collaborator

Closes None.

Changes proposed in this pull request:

@JulioAPeraza JulioAPeraza added the enhancement New feature or request label Jun 2, 2023
@JulioAPeraza
Copy link
Collaborator Author

JulioAPeraza commented Jun 2, 2023

Note, combine_analyses() only works after setting an annotation and filtering the analyses with the note "include"=False.

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 98.32% and project coverage change: +0.54 🎉

Comparison is base (fccf509) 87.82% compared to head (8206c48) 88.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   87.82%   88.36%   +0.54%     
==========================================
  Files          43       46       +3     
  Lines        5643     5940     +297     
==========================================
+ Hits         4956     5249     +293     
- Misses        687      691       +4     
Impacted Files Coverage Δ
nimare/__init__.py 100.00% <ø> (ø)
nimare/diagnostics.py 100.00% <ø> (ø)
nimare/reports/figures.py 97.95% <97.95%> (ø)
nimare/reports/base.py 98.36% <98.36%> (ø)
nimare/nimads.py 70.94% <100.00%> (+2.12%) ⬆️
nimare/reports/__init__.py 100.00% <100.00%> (ø)
nimare/workflows/cbma.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

nimare/nimads.py Show resolved Hide resolved
Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@jdkent jdkent merged commit 6c60e91 into neurostuff:main Jun 7, 2023
19 checks passed
@JulioAPeraza JulioAPeraza deleted the combine-analysis branch June 8, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants