Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility of ImageTransformer with Pandas 2.1.2 #843

Merged
merged 3 commits into from Oct 30, 2023

Conversation

JulioAPeraza
Copy link
Collaborator

Closes #842.

Changes proposed in this pull request:

  • Add new_file to a copy of images_df instead.

@JulioAPeraza JulioAPeraza added the bug Issues noting problems and PRs fixing those problems. label Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (32577f7) 89.09% compared to head (9dad264) 89.12%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
+ Coverage   89.09%   89.12%   +0.02%     
==========================================
  Files          48       49       +1     
  Lines        6108     6142      +34     
==========================================
+ Hits         5442     5474      +32     
- Misses        666      668       +2     
Files Coverage Δ
nimare/workflows/__init__.py 100.00% <100.00%> (ø)
nimare/workflows/ale.py 95.12% <ø> (ø)
nimare/workflows/misc.py 100.00% <100.00%> (ø)
nimare/transforms.py 76.66% <75.00%> (ø)
nimare/diagnostics.py 97.53% <66.66%> (-1.20%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdkent
Copy link
Member

jdkent commented Oct 30, 2023

LGTM, thanks for noticing this @JulioAPeraza

@jdkent jdkent merged commit 720c5c6 into neurostuff:main Oct 30, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility issue of ImageTransformer with Pandas 2.1.2
2 participants