Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.5 support, add tests on other Python versions, and break StanMetaRegression for Python 3.7+ #66

Merged
merged 13 commits into from Dec 17, 2021

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 17, 2021

Closes #63.

Changes proposed:

  • Remove the CircleCI config file.
  • Add a GHA workflow to run tests on Python versions 3.6-3.9.
    • I adapted nilearn's workflow.

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #66 (bcee35c) into master (ecc71fa) will decrease coverage by 0.24%.
The diff coverage is 83.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   88.87%   88.63%   -0.25%     
==========================================
  Files          10       10              
  Lines         764      774      +10     
==========================================
+ Hits          679      686       +7     
- Misses         85       88       +3     
Impacted Files Coverage Δ
pymare/results.py 81.81% <73.33%> (+0.37%) ⬆️
pymare/core.py 90.90% <75.00%> (ø)
pymare/estimators/estimators.py 83.65% <78.18%> (-1.00%) ⬇️
pymare/estimators/combination.py 92.00% <87.50%> (+0.16%) ⬆️
pymare/effectsize/base.py 95.65% <92.10%> (ø)
pymare/__init__.py 100.00% <100.00%> (ø)
pymare/effectsize/__init__.py 100.00% <100.00%> (ø)
pymare/effectsize/expressions.py 100.00% <100.00%> (ø)
pymare/estimators/__init__.py 100.00% <100.00%> (ø)
pymare/stats.py 92.30% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a794483...bcee35c. Read the comment docs.

@tsalo tsalo mentioned this pull request Dec 17, 2021
@tsalo tsalo added testing Improving testing in the project breaking-change PRs that change results or interfaces. labels Dec 17, 2021
@tsalo tsalo changed the title Run tests on all supported Python versions, and remove 3.5 support Remove 3.5 support, add tests on other Python versions, and break StanMetaRegression for Python 3.7+ Dec 17, 2021
@tsalo tsalo merged commit 7eb950f into neurostuff:master Dec 17, 2021
@tsalo tsalo deleted the test-python-versions branch December 17, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces. testing Improving testing in the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.5 support, add Python 3.8 and 3.9 support
2 participants