[FIX] DockerTestConfig

[jdkent]

fixes #14

This pull request suggests:

• change DockerTestConfig to look for the environmental variable POSTGRES_PASSWORD
• add a note in the readme on where to find the postgres password.

[codecov-commenter]

Codecov Report

Merging #15 into master will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   63.50%   63.31%   -0.19%     
==========================================
  Files          22       22              
  Lines         685      687       +2     
==========================================
  Hits          435      435              
- Misses        250      252       +2     

Impacted Files	Coverage Δ
neurostuff/example_config.py	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce336a...26cd210. Read the comment docs.

[adelavega]

The password is already pulled from the env variables in the main config, so you should just be able to change the db_name and re-set the URI to use the new variables

[adelavega]

oh crap, i guess the variable is not available. well then shoot lets revert that

[adelavega]

yeah actually instead just add these thre lines to the DockerTestConfig since i'm not sure how to access inherited class attributes:

    POSTGRES_PASSWORD = os.environ.get('POSTGRES_PASSWORD', '')
    DB_NAME = 'scout_test'
    SQLALCHEMY_DATABASE_URI = "postgres://postgres:" \
        f"{POSTGRES_PASSWORD}@postgres:5432/{DB_NAME}"

[jdkent]

Can we make an __init__ function for the class and assign these variables to self? Would that fix the issue of reassignment?

[adelavega]

yes that would be another option.

you could set DB_NAME outside of self for each instance, and then create an __init__ method in the class Config (the parent) which based on DB_NAME and POSTGRES_PASSWORD creates self.SQLALCHEMY_DATABASE_URI.

[adelavega]

Okay, I'm being super pedantic now so I apologize, but I think we can get away with only the self.SQLALCHEMY_DATABASE_URI variable being in the __init__ function on top, since all others are just plain variables.

Especially for these derivative classes, let's keep them simple just to simplify future maintenance.

Suggested change

def __init__(self):

[adelavega]

Suggested change

super().__init__()

[adelavega]

Suggested change

	self.ENV = 'production'
	ENV = 'production'

As an example, I think this should work, since the ENV variable for this derivative class will be set before the __init__ method is called.

That way, no need to mess around with super.

[jdkent]

okay, I went back to my original solution and learned(?) about when variables are instantiated in a class when referencing it as Class versus Class().

[adelavega]

Cool LGTM