[ENH] annotation key

[jdkent]

references #210

relevant changes

• add note_keys parameter to annotations endpoint
• make it so you cannot push notes with different column names than specified in note_keys
• scenarios
  • creating annotation but have not created any columns yet
    • this is okay
  • adding notes to annotation without first//concurrently filling out note_keys
    • raises error
  • adding columns to note_keys but have not created any notes
    • this is okay
  • adding/removing/changing type existing note_keys and not simultaneously changing notes
    • raises error
  • adding/removing/changing note columns without simultaneously changing note_keys
    • raises error

@adelavega @nicoalee: here is the current behavior of this pull request, let me know if this looks reasonable or if y'all would want changes in how this pull request behaves to different scenarios.

[nicoalee]

references #210

relevant changes

• add note_keys parameter to annotations endpoint

• make it so you cannot push notes with different column names than specified in note_keys

• scenarios

  • creating annotation but have not created any columns yet

    • this is okay

  • adding notes to annotation without first//concurrently filling out note_keys

    • raises error

  • adding columns to note_keys but have not created any notes

    • this is okay

  • adding/removing/changing type existing note_keys and not simultaneously changing notes

    • raises error

  • adding/removing/changing note columns without simultaneously changing note_keys

    • raises error

@adelavega @nicoalee: here is the current behavior of this pull request, let me know if this looks reasonable or if y'all would want changes in how this pull request behaves to different scenarios.

this logic looks good and intuitively makes sense to me

[adelavega]

LGTM!

My only minor concern is that using python logic prior to sql inserts could potentially slow things down, but unless we a see a specific problem w/ performance I don't think we need to worry about it too much.